Skip to content

add pagination to list api#151

Closed
hannessolo wants to merge 9 commits into
fix-mocksfrom
list-pagination
Closed

add pagination to list api#151
hannessolo wants to merge 9 commits into
fix-mocksfrom
list-pagination

Conversation

@hannessolo

Copy link
Copy Markdown
Contributor

Fix #150

@hannessolo
hannessolo marked this pull request as ready for review July 10, 2025 11:28
@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.20690% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.18%. Comparing base (406db7c) to head (3099dc1).
Report is 1 commits behind head on fix-mocks.

Files with missing lines Patch % Lines
src/routes/list-paginated.js 61.36% 17 Missing ⚠️
src/storage/object/list.js 95.65% 2 Missing ⚠️
src/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           fix-mocks     #151      +/-   ##
=============================================
- Coverage      82.21%   82.18%   -0.04%     
=============================================
  Files             39       40       +1     
  Lines           1946     2049     +103     
  Branches         330      351      +21     
=============================================
+ Hits            1600     1684      +84     
- Misses           345      364      +19     
  Partials           1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hannessolo

Copy link
Copy Markdown
Contributor Author

Up for discussion: Should this also be done for listBuckets (which is a branch of the list route, if no org is provided)? Since we're moving to single-bucket anyway, I don't really see a use for it.

@hannessolo
hannessolo marked this pull request as draft July 11, 2025 16:05
@hannessolo
hannessolo marked this pull request as ready for review July 11, 2025 16:05
@hannessolo hannessolo closed this Jul 14, 2025
@hannessolo hannessolo reopened this Jul 14, 2025
@hannessolo

Copy link
Copy Markdown
Contributor Author

Depends on #152 - merge first!

@hannessolo
hannessolo marked this pull request as draft July 14, 2025 13:44
@hannessolo
hannessolo changed the base branch from main to fix-mocks July 15, 2025 12:36
@hannessolo hannessolo closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[List] Offset & Limit

1 participant